Skip to content

Products Onboarding: Update buttons for onboarding banner #7988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 31, 2022
Merged

Products Onboarding: Update buttons for onboarding banner #7988

merged 3 commits into from
Oct 31, 2022

Conversation

@rachelmcr
Copy link
Contributor

@rachelmcr rachelmcr commented Oct 31, 2022

Closes: #7978
⚠️ Depends on #7980 ⚠️

Description

This PR updates the buttons on the products onboarding banner:

  • Removes the dismiss button
  • Call to Action redirects to the Products tab (and auto-dismisses the banner)

The dismiss button is only removed for the onboarding banner. The FeatureAnnouncementCardView now checks the view model before showing the dismiss button.

Testing

  1. Build and run the app in debug/alpha mode.
  2. Select a store with no products.
  3. Confirm the products onboarding banner appears on the My Store dashboard with no visible dismiss button.
  4. Tap the "Add a Product" call to action and confirm you are directed to the Products tab.
  5. Go back to the My Store tab and confirm the banner does not appear. (You can force close and reopen the app and the banner will reappear, as long as you haven't added any products to the store.)

Screenshots

Products Onboarding banner (no dismiss button) Just In Time Message (with dismiss button)
Simulator Screen Shot - iPhone 14 Pro - 2022-10-31 at 12 49 09 Simulator Screen Shot - iPhone 14 Pro - 2022-10-31 at 12 48 48
Products-Onboarding-Banner.mp4

Submitter Checklist

Update release notes:

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@rachelmcr rachelmcr added status: feature-flagged Behind a feature flag. Milestone is not strongly held. feature: products onboarding Related to onboarding new users to manage products labels Oct 31, 2022
@rachelmcr rachelmcr added this to the 11.1 milestone Oct 31, 2022
@rachelmcr rachelmcr marked this pull request as ready for review October 31, 2022 13:07
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 31, 2022

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr7988-2df1459 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@rachelmcr rachelmcr linked an issue Oct 31, 2022 that may be closed by this pull request
Products Onboarding: Add actions for dismiss and CTA buttons on banner #7978
Closed
@rachelmcr rachelmcr mentioned this pull request Oct 31, 2022
Merged
1 task
@Ecarrion Ecarrion self-assigned this Oct 31, 2022
Ecarrion
Ecarrion approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@Ecarrion Ecarrion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, build works good! 🚀

Do you think we should engineer the banner to be hidden when the first product is saved, rather than as soon as user taps on "Add Product"?

Base automatically changed from issue/7976-products-onboarding-banner-ui to trunk October 31, 2022 16:55
@rachelmcr
Copy link
Contributor Author

rachelmcr commented Oct 31, 2022

Do you think we should engineer the banner to be hidden when the first product is saved, rather than as soon as user taps on "Add Product"?

I considered that, but I liked this approach for a few reasons:

  • Tapping the CTA introduces the user to the Products tab, so presumably even if they don't add a product right away they'll be familiar with it and can come back even if the banner is gone.
  • They won't develop "banner blindness" — when they relaunch the app, they'll be more likely to notice the banner when it appears again (if they haven't added a product yet).
  • We won't have to re-check remote every time they visit the dashboard, in case they've added a product on the web instead of the app (less complexity, fewer API calls).

That said, we could hide the banner when the first product is saved in the app or do a fresh check (local and remote) each time the dashboard is opened, to make the banner persist until a product has been added. Let me know if you'd definitely prefer that behavior and I can make a change in a followup PR!

@rachelmcr rachelmcr merged commit 804298c into trunk Oct 31, 2022
@rachelmcr rachelmcr deleted the issue/7978-products-onboarding-banner-buttons branch October 31, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ealeksandrov ealeksandrov Awaiting requested review from ealeksandrov

1 more reviewer

@Ecarrion Ecarrion Ecarrion approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Ecarrion Ecarrion

Labels

feature: products onboarding Related to onboarding new users to manage products status: feature-flagged Behind a feature flag. Milestone is not strongly held.

Projects

None yet

Milestone

11.1

Development

Successfully merging this pull request may close these issues.

Products Onboarding: Add actions for dismiss and CTA buttons on banner

4 participants

@rachelmcr @wpmobilebot @Ecarrion